fix: instant reject all for VS Code #8489
Merged
+59
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomneyDa
requested review from
Patrick-Erichsen
and removed request for
a team
dosubot
bot
added
the
size:M
|
✅ Review Complete Code Review Summary |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Patrick-Erichsen
approved these changes
Nov 4, 2025
Collaborator
Patrick-Erichsen
left a comment
Patrick-Erichsen
left a comment
There was a problem hiding this comment.
Nice! Assuming this for speed + keeping undo stack clean? Based on Cubic comment
Comment on lines
+610
to
+614
| interface LineOperation { | ||
| type: "removed" | "added"; | ||
| line?: string; // Only for removed lines | ||
| range: vscode.Range; | ||
| } |
Collaborator
There was a problem hiding this comment.
I didn't even know you could do define an interface inside a function lol
Kind of awkward but nbd
Contributor
|
🎉 This PR is included in version 1.32.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 1.29.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of file operations for each individual diff, unified reject all with one file operation
First reject is before, second is after:
unified-reject-all-vscode.mp4
Summary by cubic
Make “Reject All” in VS Code instant by applying all diffs in one edit instead of per-diff operations. This speeds up large files and keeps undo history clean.